refactor: Port TryCastExpr proto serialization hooks#22550
Open
chakkk309 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
physical-expr
chakkk309
force-pushed
the
fix-try-cast-proto-hooks
branch
from
2920ae1 to
fe2fcd0
Compare
adriangb
requested changes
May 28, 2026
Comment on lines
+220
to
+233
| #[cfg(feature = "proto")] | ||
| use datafusion_common::DataFusionError; | ||
| use datafusion_physical_expr_common::physical_expr::fmt_sql; | ||
| #[cfg(feature = "proto")] | ||
| use datafusion_physical_expr_common::physical_expr::proto_decode::PhysicalExprDecodeCtx; | ||
| #[cfg(feature = "proto")] | ||
| use datafusion_physical_expr_common::physical_expr::proto_encode::PhysicalExprEncodeCtx; | ||
| #[cfg(feature = "proto")] | ||
| use datafusion_proto_models::protobuf::{self, physical_expr_node}; | ||
|
|
||
| #[cfg(feature = "proto")] | ||
| use crate::proto_test_util::{ | ||
| StubDecoder, StubEncoder, UnreachableDecoder, column_node, | ||
| }; |
Contributor
There was a problem hiding this comment.
It'd be easier to just make a new test module:
datafusion/datafusion/physical-expr/src/expressions/like.rs
Lines 348 to 349 in cab69a1
Contributor
Author
There was a problem hiding this comment.
Done, thanks! Already changed.
Contributor
|
#22596 adds an |
chakkk309
force-pushed
the
fix-try-cast-proto-hooks
branch
from
fe2fcd0 to
351c2b1
Compare
adriangb
approved these changes
May 29, 2026
Contributor
|
thanks! |
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Contributor
|
@chakkk309 can you please resolve conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
TryCastExprto usetry_to_proto/try_from_proto#22429.Rationale for this change
This is part of #22418, which migrates built-in
PhysicalExprimplementations away from the central protobuf serialization / deserialization chains.TryCastExprcan now own its protobuf serialization throughPhysicalExpr::try_to_protoand its deserialization throughTryCastExpr::try_from_proto, matching the pattern used by previously migrated physical expressions.What changes are included in this PR?
PhysicalExpr::try_to_protosupport forTryCastExpr.TryCastExpr::try_from_proto.TryCastExprdeserialization infrom_proto.rsthrough the new hook.TryCastExprserialization branch from the centralto_proto.rsdowncast chain.Are these changes tested?
Yes.
I ran:
Are there any user-facing changes?
No. This is an internal protobuf serialization refactor for
TryCastExpr; the wire format remains unchanged.